Skip to content

fix(certora): cheapen CreatedMarkets max LIF invariant #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathisGD merged 2 commits into from
Jun 22, 2026
+14 −2
Merged

fix(certora): cheapen CreatedMarkets max LIF invariant #1002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52fb05
fix(certora): cheapen CreatedMarkets max LIF invariant
prd-carapulse[bot] Jun 21, 2026
b9e564b
fix(certora): avoid LLTV helper definitions
prd-carapulse[bot] Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions certora/specs/CreatedMarkets.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ function marketIsCreated(Midnight.Market market) returns (bool) {

definition isLltvAllowed(uint256 lltv) returns bool = lltv == 385 * WAD() / 1000 || lltv == 625 * WAD() / 1000 || lltv == 770 * WAD() / 1000 || lltv == 860 * WAD() / 1000 || lltv == 915 * WAD() / 1000 || lltv == 945 * WAD() / 1000 || lltv == 965 * WAD() / 1000 || lltv == 980 * WAD() / 1000 || lltv == WAD();

definition maxLifAtMostTwoWad(uint256 lltv, uint256 liquidationCursor) returns bool = lltv <= WAD() && (lltv == WAD() || to_mathint(liquidationCursor) * (to_mathint(WAD()) - to_mathint(lltv)) <= (to_mathint(WAD()) / 2 + 1) * to_mathint(WAD()) - 1);
// For allowed LLTV tiers and enabled liquidationCursors, only the lowest LLTV tier can exceed 2 WAD at a cursor below WAD.
definition maxLifAtMostTwoWad(uint256 lltv, uint256 liquidationCursor) returns bool = lltv != 385 * WAD() / 1000 || liquidationCursor <= 813008130081300814;

/// RULES ///

Expand Down Expand Up @@ -76,9 +77,20 @@ strong invariant createdMarketsHaveAllowedLltv(Midnight.Market market, uint256 i
strong invariant createdMarketsHaveEnabledLiquidationCursor(Midnight.Market market, uint256 i)
marketIsCreated(market) => i < market.collateralParams.length => currentContract.isLiquidationCursorEnabled[market.collateralParams[i].liquidationCursor];

// Show that enabled liquidationCursors are at most WAD.
strong invariant enabledLiquidationCursorsAreBounded(uint256 liquidationCursor)
currentContract.isLiquidationCursorEnabled[liquidationCursor] => liquidationCursor <= WAD();

// Show that a created market has maxLif <= 2 WAD for every collateral.
strong invariant createdMarketsHaveMaxLifAtMostTwoWad(Midnight.Market market, uint256 i)
marketIsCreated(market) => i < market.collateralParams.length => maxLifAtMostTwoWad(market.collateralParams[i].lltv, market.collateralParams[i].liquidationCursor);
marketIsCreated(market) => i < market.collateralParams.length => maxLifAtMostTwoWad(market.collateralParams[i].lltv, market.collateralParams[i].liquidationCursor)
{
preserved with (env e) {
requireInvariant createdMarketsHaveAllowedLltv(market, i);
requireInvariant createdMarketsHaveEnabledLiquidationCursor(market, i);
requireInvariant enabledLiquidationCursorsAreBounded(market.collateralParams[i].liquidationCursor);
}
}

// Show that a created market cannot be deleted.
rule marketCannotBeDeleted(env e, method f, calldataarg args, Midnight.Market market) {
Expand Down