Skip to content

nit: move require in ecrecoverRatifier #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathisGD merged 2 commits into from
Jun 23, 2026
+1 −1
Merged

nit: move require in ecrecoverRatifier #1011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9ef75
Remove duplicate root cancellation check in isRatified
MathisGD Jun 23, 2026
1a442ab
Update EcrecoverRatifier.sol
MathisGD Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ratifiers/EcrecoverRatifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ contract EcrecoverRatifier is IEcrecoverRatifier {
function isRatified(Offer memory offer, bytes memory ratifierData) external view returns (bytes32) {
(Signature memory sig, bytes32 root, uint256 leafIndex, bytes32[] memory proof) =
abi.decode(ratifierData, (Signature, bytes32, uint256, bytes32[]));
require(HashLib.isLeaf(root, HashLib.hashOffer(offer), leafIndex, proof), InvalidProof());
require(!isRootCanceled[offer.maker][root], RootCanceled());
require(HashLib.isLeaf(root, HashLib.hashOffer(offer), leafIndex, proof), InvalidProof());
bytes32 structHash = keccak256(abi.encode(HashLib.offerTreeTypeHash(proof.length), root));
bytes32 domainSeparator = keccak256(abi.encode(EIP712_DOMAIN_TYPEHASH, block.chainid, address(this)));
bytes32 digest = keccak256(bytes.concat("\x19\x01", domainSeparator, structHash));
Expand Down