gas opti: no call toId#1012
Closed
MathisGD wants to merge 1 commit into
Closed
Conversation
QGarchery
approved these changes
Jun 23, 2026
|
|
||
| address public constant PERMIT2 = 0x000000000022D473030F116dDEE9F6B43aC78BA3; | ||
| address public immutable MIDNIGHT; | ||
| uint256 public immutable INITIAL_CHAIN_ID; |
Collaborator
There was a problem hiding this comment.
Suggested change
| uint256 public immutable INITIAL_CHAIN_ID; | |
| uint256 public immutable MIDNIGHT_INITIAL_CHAIN_ID; |
(optional)
adhusson
approved these changes
Jun 23, 2026
Collaborator
Author
|
at the end judged not worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saves ~1000 gas per loop, not sure if worth it