Conversation
…er-event-1780397877' into log-more
… ssh://github.com/morpho-org/midnight into log-more
MathisGD
reviewed
Jun 23, 2026
| event UpdatePosition(bytes32 indexed id_, address indexed user, uint256 creditDecrease, uint256 pendingFeeDecrease, uint256 accruedFee); | ||
| event MarketCreated(Market market, bytes32 indexed id_); | ||
| event Take(address caller, bytes32 indexed id_, uint256 units, address indexed taker, address indexed maker, bool offerIsBuy, bytes32 group, uint256 buyerAssets, uint256 sellerAssets, uint256 consumed, uint256 buyerPendingFeeIncrease, uint256 sellerPendingFeeDecrease, uint256 buyerCreditIncrease, uint256 sellerCreditDecrease, address receiver, address payer); | ||
| event Take(address caller, bytes32 indexed id_, uint256 units, address indexed taker, Offer offer, uint256 buyerAssets, uint256 sellerAssets, uint256 consumed, uint256 buyerPendingFeeIncrease, uint256 sellerPendingFeeDecrease, uint256 buyerCreditIncrease, uint256 sellerCreditDecrease, address receiver, address payer, address takerCallback); |
Collaborator
There was a problem hiding this comment.
why do you add takerCallback?
Collaborator
There was a problem hiding this comment.
I would log ratifier and ratifierData instead (see #966)
Contributor
Author
There was a problem hiding this comment.
it's in the context of this discussion where the model is "reconstruct function calls from events".
Btw there are 2 ways to go
- before i updated this PR: log everything except
bytesbecause they can be long, but then i had to have 2 events because of certora compilation. - after i updated this PR: just log everything. So 1 event now works.
Contributor
Author
There was a problem hiding this comment.
(but all this logging seems to be hard for certora)
Contributor
Author
There was a problem hiding this comment.
I would log ratifier and ratifierData instead (see #966)
agree, i forgot about ratifierData (ratifier is logged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ended up logging the whole offer to avoid 2 events