-
Notifications
You must be signed in to change notification settings - Fork 45
fix: extend liquidation auction duration #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,7 +16,7 @@ uint256 constant MAX_SETTLEMENT_FEE_90_DAYS = 0.00125e18; | |||||
| uint256 constant MAX_SETTLEMENT_FEE_180_DAYS = 0.0025e18; | ||||||
| uint256 constant MAX_SETTLEMENT_FEE_360_DAYS = 0.005e18; | ||||||
| uint32 constant MAX_CONTINUOUS_FEE = uint32(uint256(0.01e18) / uint256(365 days)); | ||||||
| uint256 constant TIME_TO_MAX_LIF = 15 minutes; | ||||||
| uint256 constant TIME_TO_MAX_LIF = 60 minutes; | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like minutes is better here because it's more natural for this kind of duration (if i want to use 40 minutes for a test, there's less change) but no big deal |
||||||
| uint256 constant MAX_COLLATERALS = 128; | ||||||
| uint256 constant MAX_COLLATERALS_PER_BORROWER = 16; | ||||||
| uint256 constant LIQUIDATION_CURSOR_LOW = 0.25e18; | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reference for why we made this change ? I feel like it would be useful if we come back to this to have the rationale (only got it informally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://morpholabs.slack.com/archives/C08A40KKN9W/p1782149030427139