Skip to content

575: fix double hashing issue #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahammedtaheer merged 9 commits into from
Jun 15, 2026
Merged

575: fix double hashing issue #576

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
40bce84
removing logs which exposes critical details
nagendra0721 Jun 9, 2026
eecbfd0
modified the log and remove master key details from log
nagendra0721 Jun 10, 2026
e54c568
remove db keystore details printing in logs
nagendra0721 Jun 10, 2026
39030c6
remove db keystore details printing in logs
nagendra0721 Jun 10, 2026
38043f5
remove keylength from log
nagendra0721 Jun 10, 2026
17f0ff3
remove db keystore details printing in logs
nagendra0721 Jun 10, 2026
f282610
#575: fix double hashing issue
nagendra0721 Jun 11, 2026
cc55c6a
Merge branch 'mosip:develop' into develop
nagendra0721 Jun 11, 2026
755427f
#575: fix double hashing issue
nagendra0721 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...er-service/src/main/java/io/mosip/kernel/tokenidgenerator/generator/TokenIDGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.mosip.kernel.tokenidgenerator.generator;

import java.math.BigInteger;
import java.nio.charset.StandardCharsets;

import io.mosip.kernel.core.logger.spi.Logger;
import io.mosip.kernel.core.util.HMACUtils2;
Expand All @@ -25,8 +26,8 @@ public class TokenIDGenerator {

public String generateTokenID(String uin, String partnerCode) {
try {
String uinHash = HMACUtils2.digestAsPlainText(HMACUtils2.generateHash((uin + uinSalt).getBytes()));
String hash = HMACUtils2.digestAsPlainText(HMACUtils2.generateHash((partnerCodeSalt + partnerCode + uinHash).getBytes()));
String uinHash = HMACUtils2.digestAsPlainText((uin + uinSalt).getBytes(StandardCharsets.UTF_8));
String hash = HMACUtils2.digestAsPlainText((partnerCodeSalt + partnerCode + uinHash).getBytes(StandardCharsets.UTF_8));
return new BigInteger(hash.getBytes()).toString().substring(0, tokenIDLength);
} catch (java.security.NoSuchAlgorithmException e) {
LOGGER.error("Error generating token ID: No such algorithm found", e);
Expand Down
Loading