Modernize Notification System and Modularize Architecture#1
Merged
mosishon merged 1 commit intoFeb 3, 2026
Merged
Conversation
This commit implements a comprehensive refactoring of the Healthy API
to improve its structural integrity and maintainability as requested.
Key changes:
- Introduced `NotificationMetadata` struct in the `model` package to
centralize alert context (ServiceName, URL, Reason, Status, etc.).
- Updated all notifiers (Mail, SMS, Payamak, Webhook) to use the new
metadata structure.
- Refactored the templating engine to support nested access to
metadata (e.g., `{{.Metadata.ServiceName}}`).
- Modularized `main.go` by moving notifier and condition loading
logic into a new `loader` package.
- Refactored `healthcheck` package to support graceful shutdown
via `context.Context` and improved logic separation.
- Cleaned up dead code and improved logging consistency using `slog`.
- Updated tests to reflect the new structure and verified nested
template access.
Co-authored-by: mosishon <61285975+mosishon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented NotificationMetadata, updated all notifiers and their templates, modularized main.go, and added graceful shutdown support.