fix: improve NOT condition logic and provide highly detailed reasons#5
Merged
Merged
Conversation
- Refactored `Evaluate` to return success reasons, allowing `NOT` to invert them into detailed "Forbidden" alerts. - Implemented specific "Expected vs Actual" messages for all condition types. - Updated `NOT` logic to be first priority and provide specific "Forbidden Status Code" messages. - Improved `loader/condition.go` robustness to prevent panics and provide better validation path logs. - Ensured clean, one-line-per-item formatting with ✘ and ✔ symbols. - Fixed existing tests to match the new reason format. Co-authored-by: mosishon <61285975+mosishon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluateto return success reasons, allowingNOTto invert them into detailed "Forbidden" alerts.NOTlogic to be first priority and provide specific "Forbidden Status Code" messages.loader/condition.gorobustness to prevent panics and provide better validation path logs.