Refactor health check evaluation for technical reasons and cleaner structure#6
Merged
Conversation
Refactored `EvaluationResult.Reason` to use `[]string` for cleaner propagation and aggregation of failure reasons. Updated leaf conditions (Status, Header, Regex, ResponseTime) to provide technical "Actual vs Expected" messages. Implemented smart inversion logic for `NOT` conditions to wrap success reasons into "Forbidden state matched" failure messages. - Changed `model.EvaluationResult.Reason` from `string` to `[]string`. - Updated `model/condition.go` evaluation logic for all condition types. - Updated `healthcheck/healthcheck.go` to join reasons at the reporting stage. - Updated and translated tests in `model/` to reflect new reason formats. Co-authored-by: mosishon <61285975+mosishon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the health check evaluation system to provide more technical and descriptive error messages. Key changes include:
stringto a[]stringfor failure reasons during evaluation, allowing for clean joining at the end.NOTcondition failure reporting by wrapping the inner success reason (e.g., "✘ Forbidden state matched: Status Code: Expected 200, Got 200").