Improve Caelus forecast synopses and hourly metrics - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both forecast tiles now show a synopsis without enlarging their existing layout. Open-Meteo and MET Norway summaries use hourly conditions, temperatures, wind, and precipitation probabilities; NWS uses its supplied period narrative when available, with a generated fallback. Open-Meteo weather codes preserve snow and thunder conditions.
Caelus adds humidity and wind ranges and hourly details. Hourly metrics use the same RH/Wind/Rain-or-Snow label order as Looking Ahead, whose precipitation text now matches the other metric colors. Long synopses support keyboard scrolling. Updates the user guide and version to
v0.26.253.5.Verification
python3 -m pytest testApparatus/test_weather_forecast.py testApparatus/test_integrated_weather_forecast.py testApparatus/test_compile_python.py -q: 54 passed.npm run validate:pr: 25 passed in local Chromium, including desktop/mobile layout limits, metric units, and long synopsis keyboard scrolling.git diff --check: passed.Contributor checklist
Maintainer verification
npm run validate:prpasses on a trusted host when the change can affect rendered UI behavior.Residual risk or unverified areas
Automated provider tests use fixtures and mocked HTTP, including NWS narrative failure and period boundaries. Live provider responses were not exercised by the automated checks. NWS narrative text retains its original units; numeric metrics follow the selected display units.