Fix desktop settings misclassification in pywebview - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A wide desktop window could receive phone-style settings when the browser reported a small screen width. Require a valid phone-sized screen and coarse pointer for the screen-width fallback, keeping JavaScript and CSS aligned while preserving compact settings for narrow windows.
Adds desktop regression coverage for General, Sensor, and Switch Settings, documents the layout rules, and updates the version to
v0.26.259.1.Verification
npm run validate:pr: 33 Chromium tests passed on macOS with Python 3.13.9, including phone navigation, saving, resizing, and desktop settings.git diff --check: passed.Contributor checklist
Maintainer verification
npm run validate:prpasses on a trusted host when the change can affect rendered UI behavior.Residual risk or unverified areas
The original long-running desktop session's failure was not reproduced in fresh native windows. The screen-width misclassification path was reproduced in Chromium and fixed; the user subsequently verified desktop and mobile Web UI behavior. Hardware control, MQTT, and onboarding were not exercised because their behavior is unchanged.