Fix Nodus pressure gauge updates and automation display names - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nodus pressure readings corrected for altitude could retain a station-pressure gauge range because Sensorius did not mirror the advertised calibration altitude, and an open dashboard kept the calibration context from its initial page load. Mirror explicit device altitude from retained metadata and propagate updated pressure context through dashboard JSON refreshes so existing gauge limits, labels, and bands update automatically. Preserve explicit zero, partial metadata, and stored readings.
Also publish automation display names from
script_json.namein Nodus ownership status, with an ID fallback for unnamed legacy rules and retained updates on rename. Update contract/configuration documentation, record the firmware metadata audit, and set versionv0.26.263.3.Verification
npm run validate:pr: 44 Chromium tests passed, including corrected/raw pressure, late calibration updates in GaugeJS and fallback canvas, and resetting calibration to zero.python3 -m pytest testApparatus/test_mqtt_ingest_liveness.py testApparatus/test_nodus_settings_schema_writes.py testApparatus/test_nodus_automation_status.py testApparatus/test_automation_contract.py -q: 288 passed, 1 skipped.git diff --check: passed.Contributor checklist
Maintainer verification
npm run validate:prpasses on a trusted host.Residual risk or unverified areas
Agent verification used simulated MQTT; live Nodus hardware and broker interactions were not independently exercised. The firmware audit documents additional metadata gaps outside this change. Deployment needs a Sensorius restart and one dashboard reload to load the updated code; later calibration changes update through normal dashboard refreshes.