Fix Nodus II MQTT display settings synchronization - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nodus II now publishes saved display settings in retained
meta/config, while its compactmetaomits them. Sensorius ignored the companion topic and replaced the existing sensor display order with factory defaults, so device-side edits were not reflected after a Nodus restart.Subscribe to and merge the saved configuration companion in either arrival order, preserve existing settings when metadata omits display fields, and preserve positional metric/style slots through correlated
meta/patchupdates. This also prevents temporary duplicate metrics during one-key-at-a-time reordering from shifting other slots. Keep full metadata support for Nodus III. Update the canonical MQTT contract and version tov0.26.270.1.Verification
Host: macOS 27.0, Python 3.13.9. Tests use isolated settings files and simulated MQTT messages, with no physical MCU or live broker required.
python3 -m pytest testApparatus/test_mqtt_ingest_liveness.py testApparatus/test_nodus_settings_schema_writes.py testApparatus/test_mqtt_ingest_auth.py testApparatus/test_homeassistant_mqtt.py testApparatus/test_compile_python.py -q— 295 passed.npm run validate:pr— 44 passed using the isolated host fixture and Playwright Chromium.git diff --check— passed.Contributor checklist
Maintainer verification
npm run validate:prpasses on a trusted host when the change can affect rendered UI behavior.Residual risk or unverified areas
The maintainer has verified other aspects of device configuration, but has not reproduced and verified this specific failure mode on hardware because of the conditions needed to trigger it. Automated replay verifies the targeted behavior. Physical Pico2W/XESP32S3 devices, the production broker, and live onboarding were not exercised by the automated checks. No firmware changes are included.