Repository navigation
Restore command subscriptions after MQTT recovery reconnect - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a clean-session MQTT recovery reconnect, Nodus could resume telemetry without restoring command subscriptions because recovery reused an already drained subscription queue. Rebuild every device command subscription and schedule switch subscriptions again, while retaining pending publications and the existing publish-before-subscribe order.
Adds regression coverage for empty and partially completed subscription queues and broker-adapter delivery of correlated display config ACK/result responses. Documents recovery validation and updates firmware to v0.26.270.1.
Related issue
Focused fix for the operator-reported co2-pmoopn config/set requests receiving no ACK/result while telemetry continued; no separate issue.
Verification
ruff check .: passed.pytest -q: 898 passed.git diff --check: passed.Checklist
ruff check .passes.pytest -qpasses.