Detailed VMI vs MI design comparison, using Quant&RoPE demo walk-through#492
Merged
Merged
Conversation
Add reader contracts, concrete tile shapes, lowering-shape examples, bug callouts, and review checklists so the RoPE and MX quant walkthroughs better connect VMI source to MI/CCE behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some algorithm background:
Note on VF performance: With current SIMD VF + optimized GM-level pipelining (tested internally, excluded here), the whole kernel can reach >3.2 TB/s BW on 950DT, thus quite memory-bound, not vector bound (i.e. the VF part is fast). In current demo PR the GM<->UB part is kept naive (single-core, no double buffer pipeline). We will polish and release end-to-end kernel as next step.
Note on syntax/styles: The biggest benefit of vmi is on type casting (abstracts away manual odd-even widening/interleaving/packing). ASC load_store_utils.h tries to abstract similar procedures, but not as elegant.