Skip to content

add Yusongwang#59

Merged
yubing744 merged 7 commits intomovefuns:mainfrom
peterwong3000:main
Aug 6, 2022
Merged

add Yusongwang#59
yubing744 merged 7 commits intomovefuns:mainfrom
peterwong3000:main

Conversation

@peterwong3000
Copy link
Copy Markdown
Contributor

No description provided.

@auto-assign auto-assign Bot requested a review from templexxx July 22, 2022 01:59
@github-actions
Copy link
Copy Markdown

Welcome to the Web3 StarTrek 🎉!

You can take a look at the Starcoin Cookbook first, there is a lot of Starcoin knowledge in it.
If you are having trouble learning about Starcoin, you can ask and discuss in the development group.

templexxx
templexxx previously approved these changes Aug 1, 2022
@jolestar jolestar requested a review from templexxx August 1, 2022 08:12
@jolestar jolestar dismissed templexxx’s stale review August 1, 2022 08:13

approval when finished

@jolestar
Copy link
Copy Markdown
Contributor

jolestar commented Aug 1, 2022

@templexxx 等 @YusongWang 学习期结束,申请毕业的时候再 approve,approve 表示同意毕业。

@peterwong3000
Copy link
Copy Markdown
Contributor Author

@WGB5445 导师在这里。

@WGB5445 WGB5445 self-requested a review August 3, 2022 03:07
Copy link
Copy Markdown
Contributor

@WGB5445 WGB5445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该学员已经提交 2 个 Move module PR,提交了 4 个 Rust PR,提交 1 个 Cookbook PR
我认为该学员已经满足毕业条件
导师 @templexxx 可以一起来评定

@peterwong3000
Copy link
Copy Markdown
Contributor Author

@jolestar @templexxx 老师看下可否毕业

@jolestar
Copy link
Copy Markdown
Contributor

jolestar commented Aug 3, 2022

@uvd @yubing744 @geometryolife 也来看看,继续 #61 前面的讨论。

另外导师制应该怎么玩也需要讨论下,机器自动分配这个貌似也不合理,有时候自动分配的导师可能没帮上忙。

Copy link
Copy Markdown
Collaborator

@uvd uvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以毕业

@jolestar
Copy link
Copy Markdown
Contributor

jolestar commented Aug 3, 2022

等我抽空发奖励。导师干脆 @YusongWang 来定对你帮助最多的 1,2 个导师吧。

@peterwong3000
Copy link
Copy Markdown
Contributor Author

@WGB5445 对我的帮助最大,给我进行了很多move的指导,非常感谢。

@geometryolife
Copy link
Copy Markdown
Collaborator

geometryolife commented Aug 3, 2022

@jolestar 让学员自己评定学习过程中哪些导师对自己的帮助比较大,会比较合理。
机器人分配的导师可以给学员一个引导,比如一开始学员不知道找哪位导师,可以提供个参考。

@yubing744 yubing744 self-requested a review August 4, 2022 01:09
@yubing744
Copy link
Copy Markdown
Collaborator

@jolestar 我看了一下,满足毕业标准。导师可以让学员自己选,如果学员不知道怎么选,学员可以@任何一个导师,导师根据学员情况推荐自己或者其他合适的导师。

@yubing744
Copy link
Copy Markdown
Collaborator

学员毕业,需要两位导师批准PR

@yubing744 yubing744 removed their request for review August 4, 2022 01:20
@uvd
Copy link
Copy Markdown
Collaborator

uvd commented Aug 4, 2022

这样吧 三分 1分 move 相关的pr 一个 1分 一篇学习文章 1分 额外的其他pr 一个 ,学员自己指出谁帮助最大,1-2个,必须两个人同意才行,可以不指定导师

@yubing744 yubing744 merged commit 7d71c40 into movefuns:main Aug 6, 2022
@jolestar
Copy link
Copy Markdown
Contributor

jolestar commented Aug 6, 2022

curl 'http://main.seed.starcoin.org/' \
  -H 'content-type: application/json' \
  --data-raw '{"jsonrpc":"2.0","method":"contract.call_v2","params":[{"function_id":"0x00000000000000000000000000000001::PriceOracle::read","args":["0x82e35b34096f32c42061717c06e44a59"],"type_args":["0x00000000000000000000000000000001::STCUSDOracle::STCUSD"]}],"id":0}'
{"jsonrpc":"2.0","result":[40206],"id":0}

1000USD = 24872STC

https://stcscan.io/main/transactions/detail/0xa340e43909439c55134b255d141c34103f245f953f536d5db269ad69d11bb199

@jolestar
Copy link
Copy Markdown
Contributor

jolestar commented Aug 6, 2022

@WGB5445 更新下你 https://github.com/starcoinorg/web3startrek/blob/main/mentors/WGB5445.md 中的账号地址,我发导师奖励

@jolestar
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants