Skip to content
This repository was archived by the owner on Nov 13, 2017. It is now read-only.

OcTree bounding box pruning - #599

Open
TheBrewCrew wants to merge 4 commits into
moveit:indigo-develfrom
TheBrewCrew:cbrew_tree_pruning
Open

OcTree bounding box pruning#599
TheBrewCrew wants to merge 4 commits into
moveit:indigo-develfrom
TheBrewCrew:cbrew_tree_pruning

Conversation

@TheBrewCrew

Copy link
Copy Markdown

This adds an optional pruning size and height to the Octomap in MoveIt perception. This pull request depends on pull request #593. This feature is enabled if the octomap_size_limit param is set. octomap_height_limit can be set to specify a height limit on the Octomap. As the robot moves, the bounding box center will be set to the root link transform and then the Octomap will be pruned to fit inside the bounding box, marking data outside the bounding box unknown and freeing up memory. This will keep the Octomap to a reasonable size as the robot moves so that the Octomap can be passed across the network faster.

@davetcoleman

Copy link
Copy Markdown
Member

I wish I knew more about this part of MoveIt! to review

otamachan pushed a commit to otamachan/moveit_ros that referenced this pull request Oct 22, 2017
* Use planGraspsAndPick with empty string

Make it possible to use planGraspsAndPick even though the user did not provide
any object.
Now, if planGraspsAndPick is called with an empty string then planGraspsAndPick is called again
with an empty moveit_msgs::CollisionObject.

This change causes trouble in the executeAttachObject function, because there is no object to be attached.
The function returns false and the pick is being abborted after the grasp.
Thus we just return true in that function when the id of the object is an empty string.

* Empty string default value for planGraspsAndPick
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants