Skip to content
This repository was archived by the owner on Nov 13, 2017. It is now read-only.

Added param to load Octomap from file at startup - #604

Open
TheBrewCrew wants to merge 1 commit into
moveit:indigo-develfrom
TheBrewCrew:cbrew_octomap_load
Open

Added param to load Octomap from file at startup#604
TheBrewCrew wants to merge 1 commit into
moveit:indigo-develfrom
TheBrewCrew:cbrew_octomap_load

Conversation

@TheBrewCrew

Copy link
Copy Markdown

This adds a param (/move_group/octomap_file) that can be set to load a binary Octomap file (.bt) into the Octomap when the MapMonitor starts. The map can be created using the save_map script in move_group/scripts.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any good reason to explicitly disable change detection here? This seems unrelated to the PR.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting change detection to false is necessary to make this pull request properly interact with pull request #602.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something, but why isn't this part of #602 then? It seems unrelated to this feature as it goes into the loadMapCallback and that is already present in the original code.

In general - is this even required? The only problem that I see would be that a tree load with enabled change detection does not reflect the full tree change correctly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing #602 (now #636) I believe that this line should not be here (in this PR), but here should actually go to the load via param in line 102.

@dornhege

Copy link
Copy Markdown
Contributor

This merge should be held until after #636 is merged to prevent conflicts and also disable change detection initially if an octree is loaded with this mechanism.

otamachan pushed a commit to otamachan/moveit_ros that referenced this pull request Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants