annotations: fix shadowing issue #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
In addition to the fix of handling the missing annotation declaration, this PR changes resolution to be a bit smarter and consider the "kind" of declaration during search, instead of just taking the first one it finds. I guess that's the way to go? Alternatively, one could just report an error of a kind mismatch, no? |
Philipp15b
requested changes
Dec 19, 2025
| } | ||
|
|
||
| /// Get all annotation declarations that can be used on top of statements. These are slicing and encoding annotations. | ||
| pub fn get_statement_annotations(&self) -> IndexMap<Symbol, Rc<DeclKind>> { |
Collaborator
There was a problem hiding this comment.
I don't understand why you want to create this new IndexMap instead of just creating a version of get for annotations specifically? Seems wasteful.
|
|
||
| match self.tcx.get(*ident).as_deref() { | ||
| None => {} // Declaration not found | ||
| // Resolve the annotation ident to the declaration |
Collaborator
There was a problem hiding this comment.
Comment formatting and dots at end of sentences
Collaborator
|
Clippy failure was unrelated and is fixed on main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues by resolving annotations to only intrinsic annotation declarations, skipping the current scope. Hence other declaration kinds can't shadow annotation declarations anymore.