Skip to content

Improve the functionality and correctness of the JEXL debugger page #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freshstrangemusic merged 9 commits into from
Jul 8, 2026
Merged

Improve the functionality and correctness of the JEXL debugger page #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e8386b7
getExpression is not an async function
freshstrangemusic Jun 26, 2026
8f3dbd9
Support property accessors on object and array literals
freshstrangemusic Jun 26, 2026
e57974f
Simplify getExpression() for ObjectLiterals
freshstrangemusic Jun 26, 2026
2bd711b
Fix string re-quoting in jexlParser
freshstrangemusic Jun 27, 2026
e9d5aeb
Evaluate expressions before attempting to debug them
freshstrangemusic Jun 27, 2026
f9ea40a
Make the JEXL Debugger Page more visually consistent
freshstrangemusic Jun 24, 2026
032519a
Support undefined values in the targeting context and evaluator output
freshstrangemusic Jul 7, 2026
b556c39
Identify which context attributes are not reported in telemetry
freshstrangemusic Jun 24, 2026
e20440f
Report unrecorded attributes and prefs from evaluated expressions
freshstrangemusic Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/apis/nimbus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ ChromeUtils.defineLazyGetter(this, "_ExperimentAPI", () => {
}
});

ChromeUtils.defineLazyGetter(this, "TargetingContextRecorder", () => {
try {
return ChromeUtils.importESModule(
"moz-src:///toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs",
);
} catch {
return ChromeUtils.importESModule(
"resource://nimbus/lib/TargetingContextRecorder.sys.mjs",
);
}
});

ChromeUtils.defineLazyGetter(
this,
"ExperimentAPI",
Expand Down Expand Up @@ -296,7 +308,7 @@ var nimbus = class extends ExtensionAPI {
ExperimentManager.createTargetingContext(),
);

const targetingParameters = {
const values = {
...environment,
...localContext,
// This code is based on the implementation from:
Expand All @@ -309,7 +321,11 @@ var nimbus = class extends ExtensionAPI {
os: ClientEnvironmentBase.os,
};

return targetingParameters;
return {
attrs: Object.keys(TargetingContextRecorder.ATTRIBUTE_TRANSFORMS),
prefs: Object.keys(TargetingContextRecorder.PREFS),
values,
};
},

async updateRecipes() {
Expand Down
12 changes: 9 additions & 3 deletions src/types/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ declare module "mozjexl/lib/parser/Parser" {
type Identifier = {
type: "Identifier";
value: string;
from?: Identifier;
from?: ASTNode;
};

type ArrayLiteral = {
Expand Down Expand Up @@ -136,6 +136,12 @@ type CurrentCollection = {
prefValue: string;
};

type ClientContextValue = object | string | boolean | number | Date | undefined;
type ClientContext = {
attrs: string[];
prefs: string[];
values: Record<string, ClientContextValue>;
};
declare namespace browser.experiments.nimbus {
function enrollInExperiment(
jsonData: object,
Expand All @@ -155,9 +161,9 @@ declare namespace browser.experiments.nimbus {

function setCollection(collectionId: string): Promise<void>;

function evaluateJEXL(expression: string, context: object): Promise<object>;
function evaluateJEXL(expression: string, context: object): Promise<unknown>;

function getClientContext(): Promise<object>;
function getClientContext(): Promise<ClientContext>;

function injectInactiveEnrollment(
recipe: object,
Expand Down
Loading
Loading