Bump to redux v5#14333
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14333 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 269 269
Lines 10750 10750
Branches 3314 3314
=======================================
Hits 10550 10550
Misses 187 187
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I guess the head-scratcher for me is that the issue makes it seem like this is a big change, that switches out the core of redux to another lib, and we should remove/replace other associated bits of tech too.... and the actual PR just bumps three version numbers with no code changes. So redux 4.x to 5.x is completely forwards compatible? Do you recommend follow-up work to refactor our reducer code, and switch out packages such as redux-saga, like the issue talks about, or is that actually unnecessary? I do note that the last release of redux (5.0.1) was in December 2023 (which would generally be regarded as unmaintained/abandoned even in the python world!) |
|
@eviljeff, in short, I wanted this to be as small and testable as possible as it's 3 major upgrades. I did start at migrating everything to the recommended I've logged an issue for this, as I feel is warrants discussion; mozilla/addons#16340 |
eviljeff
left a comment
There was a problem hiding this comment.
If everything works with redux v5 👍
But I do think in follow-up work we need look into moving off redux if it's no longer actively developed.
Fixes mozilla/addons#2170
react-reduxredux@reduxjs/toolkit