Skip to content

Bump to redux v5#14333

Open
nothingrandom wants to merge 3 commits into
masterfrom
redux-upgrade-v5
Open

Bump to redux v5#14333
nothingrandom wants to merge 3 commits into
masterfrom
redux-upgrade-v5

Conversation

@nothingrandom

Copy link
Copy Markdown
Member

Fixes mozilla/addons#2170

Package Old Version New Version
react-redux 8.1.3 9.3.0
redux 4.1.0 5.0.1
@reduxjs/toolkit 1.9.7 2.12.0

@nothingrandom
nothingrandom requested review from a team and eviljeff and removed request for a team July 20, 2026 15:59
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (c267bbe) to head (35f2de4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14333   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         269      269           
  Lines       10750    10750           
  Branches     3314     3314           
=======================================
  Hits        10550    10550           
  Misses        187      187           
  Partials       13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread webpack.dev.config.babel.js Outdated
@eviljeff

Copy link
Copy Markdown
Member

I guess the head-scratcher for me is that the issue makes it seem like this is a big change, that switches out the core of redux to another lib, and we should remove/replace other associated bits of tech too.... and the actual PR just bumps three version numbers with no code changes.

So redux 4.x to 5.x is completely forwards compatible? Do you recommend follow-up work to refactor our reducer code, and switch out packages such as redux-saga, like the issue talks about, or is that actually unnecessary? I do note that the last release of redux (5.0.1) was in December 2023 (which would generally be regarded as unmaintained/abandoned even in the python world!)

@nothingrandom

Copy link
Copy Markdown
Member Author

@eviljeff, in short, I wanted this to be as small and testable as possible as it's 3 major upgrades.

I did start at migrating everything to the recommended createSlice, but due to redux-saga and SSR choices, they'd either need a lot of customization or other things would need an overhaul. Basically, this is a chunk that works without it spinning into something no one wants to review 😅

I've logged an issue for this, as I feel is warrants discussion; mozilla/addons#16340

@eviljeff eviljeff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything works with redux v5 👍

But I do think in follow-up work we need look into moving off redux if it's no longer actively developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update redux to the latest version and look into @reduxjs/toolkit

3 participants