Skip to content

Record which blocks were performed on ban for each user, revert them on unban#24570

Draft
diox wants to merge 1 commit intomozilla:masterfrom
diox:automatic-unblock-on-unban
Draft

Record which blocks were performed on ban for each user, revert them on unban#24570
diox wants to merge 1 commit intomozilla:masterfrom
diox:automatic-unblock-on-unban

Conversation

@diox
Copy link
Member

@diox diox commented Mar 5, 2026

Fixes mozilla/addons#16038

Testing

Base scenario:

  • Mass ban one a user from the admin
  • Check that the add-ons they were the sole author of are disabled and blocked (silently)
  • Check that in the user admin, you can see the links to blocklistsubmissions in "content disabled on ban"
  • Unban the user from the admin
  • Check that blocks on their add-ons made during the bans are reverted

Variations (can be mixed together for even more fun)

  • With multiple users at once
  • With multiple users at once that are developing add-ons in common
  • With user(s) that are authors of add-ons with other users not involved in the ban: those add-ons should not be disabled or blocked
  • With a user that is a developer of an add-on we already entirely blocked before: it shouldn't be recorded as blocked as part of the ban, and shouldn't be unblocked on unban
  • With a user that is a developer of an add-on that already had versions hard blocked before: those versions shouldn't be recorded as blocked as part of the ban, and shouldn't be unblocked on unban, but any other version should be
  • With a user that is a developer of an add-on that already had versions soft blocked before: those versions should be hard-blocked on banned, and go back to soft-blocked on unban, but any other version should be blocked and unblocked as before.

@diox diox force-pushed the automatic-unblock-on-unban branch from baa24e2 to 2a57276 Compare March 5, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Unblock add-ons blocked as part of a ban when unbanning

1 participant