Conversation
…ast_seen + baseline_active_users and baseline_active_users_aggregates_v2
d6a112d to
bfe08d9
Compare
This comment has been minimized.
This comment has been minimized.
chelseyklein
reviewed
Mar 2, 2026
| name: policies_is_enterprise | ||
| type: BOOLEAN | ||
| description: |- | ||
| Attempt to determine if the user is an enterprise user based on various signals. |
Contributor
There was a problem hiding this comment.
It might be good to elaborate on why this is an "attempt" for better understanding to users
Contributor
Author
There was a problem hiding this comment.
I copied this description from the Glean dictionary.
Integration report for "feat(DENG-8905): add policies_is_enterprise firefox_desktoip.baseline_active_users_aggregates_v2"
|
chelseyklein
reviewed
Mar 2, 2026
| mode: NULLABLE | ||
| description: Unique token created at Firefox download time using the Microsoft Store. | ||
| - mode: NULLABLE | ||
| name: policies_is_enterprise |
Contributor
There was a problem hiding this comment.
does query.sql also need to be updated for baseline_active_users_v1 to bring this column into the table??
Contributor
Author
There was a problem hiding this comment.
No, because the query is doing a SELECT * so it will be implicitly included.
chelseyklein
approved these changes
Mar 2, 2026
Contributor
chelseyklein
left a comment
There was a problem hiding this comment.
approved pending answer to q on query.sql for baseline_active_users_v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(DENG-8905): add policies_is_enterprise to glean_telemetry.active_users_aggregates
This also includes adding the
policies_is_enterprisefield upstream to glean_usage generatorbaseline_clients_daily,baseline_clients_first_seen, andbaseline_clients_last_seentemplates,firefox_desktop_derived.baseline_active_users_v1, andfirefox_desktop.baseline_active_users_aggregates_v2.