Bug 2037079 - Add support for captive portal#1129
Open
mkaply wants to merge 1 commit into
Open
Conversation
lissyx
reviewed
Jul 9, 2026
lissyx
reviewed
Jul 9, 2026
lissyx
reviewed
Jul 9, 2026
lissyx
reviewed
Jul 9, 2026
lissyx
reviewed
Jul 9, 2026
Contributor
Author
|
I think a point is missed here. Captivity isn't just that happens at startup. It can happen at any time during the session which is why we handle it with observers and let network calls timeout. |
lissyx
reviewed
Jul 9, 2026
lissyx
reviewed
Jul 9, 2026
Contributor
Author
|
This is not ready for review again yet. Accidentally force pushed before I tested. |
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
changed the title
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
reviewed
Jul 10, 2026
lissyx
approved these changes
Jul 10, 2026
lissyx
left a comment
lissyx
left a comment
Contributor
There was a problem hiding this comment.
r=me with all the remainders addressed, we verified on slack what was working/broken on my local setup as well
Enterprise Firefox never showed the captive-portal experience: on a network behind a sign-in page the FELT login window couldn't reach the enterprise console and the user was stuck. Detect the portal, let the user sign in to the network from inside the login window, then continue to console sign-in. - Stop routing captivedetect.canonicalURL and the connectivity-service URLs through the HTTPS console; they must stay plaintext so a portal can intercept. - Add a captive-portal banner (reusing desktop Firefox's neterror strings) with a button that opens the portal's sign-in page in a browser embedded in the FELT window. Teardown/resume is driven by CaptivePortalService's connectivity signal, not the portal's navigation. - Gate the startup update check on captive-portal state so we never start a network update check while stuck behind a portal. - Clear the private cookie jar when tearing the portal down so the untrusted portal's cookies aren't collected into the enterprise session. - CaptivePortal lives in its own module (enterprise/modules) with a small injected-callback interface; it never reaches back into window.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2037079
This patch updates our update/login flow to support captive portals
Screenshots (I have not received a design for this. I have requested it)