Bug 2026616 - Fix session loss on browser restart#1156
Draft
jporter-dev wants to merge 1 commit into
Draft
Conversation
jporter-dev
added
bug
jporter-dev
force-pushed
the
enterprise-bug2026616-felt-restart-session-race
branch
5 times, most recently
from
July 17, 2026 15:46
63e479b to
1cc92e3
Compare
jporter-dev
changed the title
jporter-dev
force-pushed
the
enterprise-bug2026616-felt-restart-session-race
branch
from
July 17, 2026 21:31
1cc92e3 to
0222422
Compare
lissyx
reviewed
Jul 17, 2026
Comment on lines
+319
to
+323
| * Stops the current browser for a restart once it has persisted its session. | ||
| * We wait for the browser's felt-firefox-session-flushed signal (with a | ||
| * bounded fallback) rather than a full clean shutdown, which can hang, then | ||
| * stop the process so the relaunch is deterministic and the session is never | ||
| * lost. Resolves once the stopped process has been reaped. |
Contributor
There was a problem hiding this comment.
That comment makes me worried: why would a full clean shutdown hang? There are no good reason.
jporter-dev
force-pushed
the
enterprise-bug2026616-felt-restart-session-race
branch
2 times, most recently
from
July 17, 2026 22:46
65008a0 to
ed03007
Compare
jporter-dev
force-pushed
the
enterprise-bug2026616-felt-restart-session-race
branch
from
July 18, 2026 00:57
ed03007 to
98bb638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2026616
When a FELT-managed browser requests a restart,
FeltProcessParentforce-kills the browser process immediately and then relaunches it. This races the browser's shutdown before its session store has flushed to disk, so the relaunch comes up looking like a crash instead of restoring the previous session.Testing
Steps to verify changes:
about:preferences, ensure "Open previous windows and tabs" is uncheckedabout:profilesand click "Restart Normally"Services.startup.quit(Ci.nsIAppStartup.eRestart | Ci.nsIAppStartup.eAttemptQuit);Services.obs.notifyObservers(null, "felt-update-ready");, then click "Update Available - Restart Now"Expected result:
The browser exits cleanly and relaunches once, with the previous session/tabs restored.