Bug 2056556 - Require local opt-in to sync passwords and payment methods#1175
Open
beurdouche wants to merge 1 commit into
Open
Bug 2056556 - Require local opt-in to sync passwords and payment methods#1175beurdouche wants to merge 1 commit into
beurdouche wants to merge 1 commit into
Conversation
…ods and warn that enterprise Sync is not end-to-end encrypted In enterprise builds the Sync key is provisioned by the management console, so synced data is encrypted at rest but not end-to-end encrypted (the organization can access it). Prevent the Sync enterprise policy from force-enabling the passwords and payment-method engines. They now default off in enterprise builds and can only be turned on by an explicit local choice; the policy may still disable (lock off) these engines. Other engines are unaffected. Add a red warning in about:preferences - in both the redesigned and legacy Sync panes and in the "Choose what to sync" dialog - stating that synced data is encrypted at rest but not end-to-end encrypted, with passwords and payment methods called out as opt-in only. Also fixes stale helper imports in SyncPolicy.sys.mjs and adds xpcshell and browser tests (gated to enterprise builds).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In enterprise builds the Sync key is provisioned by the management console, so synced data is encrypted at rest but not end-to-end encrypted (the organization can access it).
Prevent the Sync enterprise policy from force-enabling the passwords and payment-method engines. They now default off in enterprise builds and can only be turned on by an explicit local choice; the policy may still disable (lock off) these engines. Other engines are unaffected.
Add a red warning in about:preferences - in both the redesigned and legacy Sync panes and in the "Choose what to sync" dialog - stating that synced data is encrypted at rest but not end-to-end encrypted, with passwords and payment methods called out as opt-in only.
Also fixes stale helper imports in SyncPolicy.sys.mjs and adds xpcshell and browser tests (gated to enterprise builds).