Bug 2040302 - Disable primary password controls in the Settings Redesign for enterprise-managed profiles#1176
Open
beurdouche wants to merge 1 commit into
Conversation
…ign for enterprise-managed profiles In enterprise builds the primary password is managed transparently and the user must not be able to add, change or remove it. The legacy about:preferences pane disables the controls imperatively in _initMasterPasswordUI(), but the Settings Redesign renders them through the declarative Preferences.addSetting() framework, whose disabled state is driven solely by each setting's disabled() callback. The addPrimaryPassword, changePrimaryPassword and turnOffPrimaryPassword settings never consulted LoginHelper.isEnterpriseManagedPrimaryPassword(), so the redesign left them enabled. Add the enterprise check to those callbacks, restore it on the shared _initMasterPasswordUI() button (dropped in an earlier refactor), and cover the redesign behaviour with a browser-chrome test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In enterprise builds the primary password is managed transparently and the user must not be able to add, change or remove it. The legacy about:preferences pane disables the controls imperatively in _initMasterPasswordUI(), but the Settings Redesign renders them through the declarative Preferences.addSetting() framework, whose disabled state is driven solely by each setting's disabled() callback.
The addPrimaryPassword, changePrimaryPassword and turnOffPrimaryPassword settings never consulted LoginHelper.isEnterpriseManagedPrimaryPassword(), so the redesign left them enabled. Add the enterprise check to those callbacks, restore it on the shared _initMasterPasswordUI() button (dropped in an earlier refactor), and cover the redesign behaviour with a browser-chrome test.