Bug 2056566 - For enterprise addon install complete event, inherit keys from install event. Add missing key#1179
Merged
jonathanmendez merged 1 commit intoJul 22, 2026
Conversation
…ys from install event. Add missing key
jonathanmendez
added
the
branch:main
There was a problem hiding this comment.
Pull request overview
This PR updates the add-ons manager Glean telemetry definitions and recording so the enterprise-specific install_complete event stays aligned with the standard add-on install event, including the recently-added site_permission extra key.
Changes:
- Refactors
addons_manager.install_completeinmetrics.yamlto inherit the sameextra_keysmap as the core install/update event (plus the enterprise-onlyaddon_name). - Records the
site_permissionextra key in the enterpriseinstall_completeevent payload (matching the install event behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| toolkit/mozapps/extensions/metrics.yaml | Introduces an anchored extra_keys map for install/update events and merges it into the enterprise install_complete event to prevent key drift. |
| toolkit/mozapps/extensions/AddonManager.sys.mjs | Adds site_permission to the enterprise install-complete telemetry event recording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5924
to
+5925
| // will be undefined for non-site permission addons | ||
| site_permission: install.newSitePerm, |
jporter-dev
approved these changes
Jul 22, 2026
jonathanmendez
merged commit Jul 22, 2026
129181c
into
mozilla:enterprise-main
78 of 82 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2056566
A recent change added an extra key
site_permissionto the addon install metric, causing drift for our enterprise-specific addon install-completed event. I've updated the yaml so that the enterprise event inherits the keys from the regular event, just adding the enterprise-specificaddon_name. I've included the new key's data in the recording of the event.