Skip to content

Bug 2019348 - Enterprise: fix test_no_window_update_restart.py #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lissyx wants to merge 1 commit into
base: enterprise-main
Choose a base branch
from
Draft

Bug 2019348 - Enterprise: fix test_no_window_update_restart.py #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion toolkit/mozapps/update/UpdateService.sys.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ function areDirectoryEntriesWriteable(aDir) {
let items = aDir.directoryEntries;
while (items.hasMoreElements()) {
let item = items.nextFile;
if (!item.isWritable()) {
if (item && item.exists() && !item.isWritable()) {
LOG("areDirectoryEntriesWriteable - unable to write to " + item.path);
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion toolkit/mozapps/update/tests/marionette/manifest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ tags = "os_integration"

["test_no_window_update_restart.py"]
run-if = [
"os == 'mac' && !enterprise", # Bug 2019348 - Test is failing and there is a "profile missing" window visible

@lissyx lissyx Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this missing profile window may likely have been fixed by bug 2024587

"os == 'mac'"
]
reason = "Test of a mac only feature"