Bug 2039213 - Fix customizableui tests for enterprise build#911
Open
victhorlopez wants to merge 1 commit into
Open
Bug 2039213 - Fix customizableui tests for enterprise build#911victhorlopez wants to merge 1 commit into
victhorlopez wants to merge 1 commit into
Conversation
victhorlopez
force-pushed
the
bug/2039213
branch
4 times, most recently
from
May 28, 2026 11:28
05b8ed3 to
5569c8b
Compare
victhorlopez
commented
May 29, 2026
| "true", | ||
| "FxA button is overflowing" | ||
| ok(customizableButton, buttonId + " was found"); | ||
| await TestUtils.waitForCondition( |
Contributor
Author
There was a problem hiding this comment.
the original conditional here, ok(customizableButton, buttonId + " was found"); was working because the first button that overflows is the fxa, the email button takes more time to overflow, and that shows the original check was racy...
victhorlopez
marked this pull request as ready for review
May 29, 2026 12:03
1rneh
requested changes
Jun 2, 2026
1rneh
left a comment
Contributor
There was a problem hiding this comment.
Thanks, some small nits and one blocker related to using SpecialPowers.pushPrefEnv when instrumenting user preferences in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugzilla: Bug-2039213
fixes:
In general tests fail with
uncaught rejection: DocumentFragment.querySelector: '#' is not a valid selector, this is because the we have two html link elements in the pannel, and the CustomizableUI uses id's programatically. I moved those ones in browser.xhtml as other items are doing.browser_976792_insertNodeInWindow.jsis fixed upstream (see dependencies)Dependencies / Related Issues
Screenshots
Testing
See test pass