Skip to content

Bug 2039213 - Fix customizableui tests for enterprise build#911

Open
victhorlopez wants to merge 1 commit into
mozilla:enterprise-mainfrom
victhorlopez:bug/2039213
Open

Bug 2039213 - Fix customizableui tests for enterprise build#911
victhorlopez wants to merge 1 commit into
mozilla:enterprise-mainfrom
victhorlopez:bug/2039213

Conversation

@victhorlopez

@victhorlopez victhorlopez commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

Bugzilla: Bug-2039213

fixes:

In general tests fail with uncaught rejection: DocumentFragment.querySelector: '#' is not a valid selector, this is because the we have two html link elements in the pannel, and the CustomizableUI uses id's programatically. I moved those ones in browser.xhtml as other items are doing.

  • browser_884402_customize_from_overflow.js uses the FxA button from the "overflowable" menu and tries to customize it, because our badge is not customizable (i.e non removable) and we do not have FxA button, I used another button
  • browser_923857_customize_mode_event_wrapping_during_reset.js same as above, I just used email button
  • browser_editcontrols_update.js the test does different things, the problem in here is the expectation that we reach the "overflow" state, our "enterprise badge" has usually no size on this tests, as such I gave it a fake logo, to have a "organic size" (instead of just setting some random width)
  • The test browser_976792_insertNodeInWindow.js is fixed upstream (see dependencies)

Dependencies / Related Issues


Screenshots


Testing

@victhorlopez victhorlopez self-assigned this May 18, 2026
@victhorlopez victhorlopez added branch:main PR that should be merged on enterprise-main branch test-greening Fixes failing or flaky tests to restore passing CI status without changing core application logic labels May 18, 2026
@victhorlopez
victhorlopez force-pushed the bug/2039213 branch 4 times, most recently from 05b8ed3 to 5569c8b Compare May 28, 2026 11:28
"true",
"FxA button is overflowing"
ok(customizableButton, buttonId + " was found");
await TestUtils.waitForCondition(

@victhorlopez victhorlopez May 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original conditional here, ok(customizableButton, buttonId + " was found"); was working because the first button that overflows is the fxa, the email button takes more time to overflow, and that shows the original check was racy...

@victhorlopez
victhorlopez requested a review from 1rneh May 29, 2026 12:01
@victhorlopez
victhorlopez marked this pull request as ready for review May 29, 2026 12:03

@1rneh 1rneh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some small nits and one blocker related to using SpecialPowers.pushPrefEnv when instrumenting user preferences in tests.

Comment thread browser/components/customizableui/test/browser_884402_customize_from_overflow.js Outdated
Comment thread browser/components/customizableui/test/browser_editcontrols_update.js Outdated
@victhorlopez
victhorlopez requested a review from 1rneh June 8, 2026 07:06
@victhorlopez victhorlopez assigned 1rneh and unassigned victhorlopez Jun 8, 2026
@1rneh
1rneh removed their request for review June 9, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:main PR that should be merged on enterprise-main branch test-greening Fixes failing or flaky tests to restore passing CI status without changing core application logic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants