Bug 2044296 - Disable Sync/FxA related tests for firefox enterprise by victhorlopez · Pull Request #988 · mozilla/enterprise-firefox

victhorlopez · 2026-06-02T11:48:33Z

Description

Bugzilla: Bug-2044296

Skip FxA-related tests (sync, asrouter menu messages) since enterprise builds do not include Firefox Accounts UI functionality

Dependencies / Related Issues

Depends on:

Screenshots

Testing

Added tests
Manual testing performed

victhorlopez · 2026-06-02T13:25:42Z

I added browser_contextmenu_sendtab.js link cause it was failing and has a bunch of FxA logic

1rneh

I added browser_contextmenu_sendtab.js link cause it was failing and has a bunch of FxA logic

Sending tabs is supported in enterprise build so I took a closer look at what was failing as we don't generally want to have regressed sending tabs to other devices.

It seems only test_sendTabToDevice_showsConfirmationHint_fxa and test_sendTabToDevice_showsConfirmationHint_onOverflowMenu fail because they trigger and assert that the fxa toolbar button becomes visible.
I noticed test_tab_contextmenu_send_to_mobile passed although we don't want to support Firefox Enterprise on mobile, hence we shouldn't offer that option.

In conclusion, instead of skipping the whole test suite, we can wrap those three tests if !AppConstants.MOZ_ENTERPRISE (unfortunately we can't skip-if on a task level) and we should also fix not supporting sending tabs to mobile and have test coverage for that.

victhorlopez · 2026-06-02T16:23:28Z

I added browser_contextmenu_sendtab.js link cause it was failing and has a bunch of FxA logic

Sending tabs is supported in enterprise build so I took a closer look at what was failing as we don't generally want to have regressed sending tabs to other devices.
1. It seems only `test_sendTabToDevice_showsConfirmationHint_fxa` and `test_sendTabToDevice_showsConfirmationHint_onOverflowMenu` fail because they trigger and assert that the fxa toolbar button becomes visible.

2. I noticed `test_tab_contextmenu_send_to_mobile` passed although we don't want to support Firefox Enterprise on mobile, hence we shouldn't offer that option.
In conclusion, instead of skipping the whole test suite, we can wrap those three tests if !AppConstants.MOZ_ENTERPRISE (unfortunately we can't skip-if on a task level) and we should also fix not supporting sending tabs to mobile and have test coverage for that.

okay will do, there is this by the way for skipping on task level
#826 (comment)

https://searchfox.org/firefox-main/rev/1372522d3de2c9aeedc8020ec8d81326f1a9516e/browser/components/asrouter/tests/browser/browser_asrouter_newtab_multistage_messages.js#144

1rneh · 2026-06-02T16:28:46Z

okay will do, there is this by the way for skipping on task level #826 (comment)

https://searchfox.org/firefox-main/rev/1372522d3de2c9aeedc8020ec8d81326f1a9516e/browser/components/asrouter/tests/browser/browser_asrouter_newtab_multistage_messages.js#144

Nice find! Thanks for sharing!

victhorlopez · 2026-06-03T11:54:40Z

I added browser_contextmenu_sendtab.js link cause it was failing and has a bunch of FxA logic

Sending tabs is supported in enterprise build so I took a closer look at what was failing as we don't generally want to have regressed sending tabs to other devices.
1. It seems only `test_sendTabToDevice_showsConfirmationHint_fxa` and `test_sendTabToDevice_showsConfirmationHint_onOverflowMenu` fail because they trigger and assert that the fxa toolbar button becomes visible.

2. I noticed `test_tab_contextmenu_send_to_mobile` passed although we don't want to support Firefox Enterprise on mobile, hence we shouldn't offer that option.
In conclusion, instead of skipping the whole test suite, we can wrap those three tests if !AppConstants.MOZ_ENTERPRISE (unfortunately we can't skip-if on a task level) and we should also fix not supporting sending tabs to mobile and have test coverage for that.

1- I did the change
2- Let me know what should we do exactly here, send_Tab just checks which devices are available and if they are mobile devices only the label changes code

I would expect this never retrieves mobile devices from backend link otherwise we would need to filter them in that function for enterprise

victhorlopez · 2026-06-03T12:04:17Z

Use this in the url ?w=1 to get rid of the indentation noise..

lissyx · 2026-06-03T12:20:24Z

+        availableCommands: {
+          "https://identity.mozilla.com/cmd/open-uri": "baz",
+        },


was this rewrote by linter?

yes, I run ./mach lint --fix

I'm wondering if it warrants an upstream fix as well to make sure we reduce risks of conflicts

do you have ideas for a workaround? Should I add a helper function add_task_with_skip()

so we can have the original indentation? (and the test skips enterprise by default)

I'm not worried about conflicts on the add_task changes at the prototype place, rather the rest of the linting changes. I assume without you get a linting failures?

I assume without you get a linting failures? let me try

It does not pass,
https://treeherder.mozilla.org/jobs?repo=enterprise-firefox-pr&revision=f122484530df9427edd78066b80538201e5e23de&selectedTaskRun=MuFUOBBGTWquSvGfeFc_ag.0

then we have to live with it :(

still worth I think fixing upstream to avoid risk of merge regressing just the lint?

what's your opinion @1rneh

lissyx · 2026-06-03T12:20:31Z

+        availableCommands: {
+          "https://identity.mozilla.com/cmd/open-uri": "boo",
+        },


was this rewrote by linter?

victhorlopez · 2026-06-03T14:30:11Z

Apologies for the noise... I had to disable yet another one browser/base/content/test/sync/browser_sendtab_telemetry.js
Maybe this one deserves some other bug (at least so it can be assessed later on whether badge menu needs to have similar metrics). It is about glean metrics with FxA interaction

Glean.fxaAvatarMenu.sendTabExposed "send tab" feature shown in the FxA avatar menu
Glean.fxaAvatarMenu.sendTabOpened send tab submenu opened from avatar menu
Glean.fxaAvatarMenu.clickSendTab user clicked a device in the avatar menu
Glean.fxaAppMenu.sendTabExposed / .sendTabOpened / .clickSendTab same events but from the hamburger menu

victhorlopez added branch:main PR that should be merged on enterprise-main branch test-greening Fixes failing or flaky tests to restore passing CI status without changing core application logic labels Jun 2, 2026

victhorlopez force-pushed the bug/2044296 branch from 3ead875 to f06d35e Compare June 2, 2026 12:06

victhorlopez marked this pull request as ready for review June 2, 2026 12:32

victhorlopez requested review from 1rneh and lissyx June 2, 2026 12:32

lissyx approved these changes Jun 2, 2026

View reviewed changes

1rneh approved these changes Jun 2, 2026

View reviewed changes

victhorlopez force-pushed the bug/2044296 branch from f06d35e to 572d0f0 Compare June 2, 2026 13:22

victhorlopez requested review from 1rneh and lissyx June 2, 2026 13:30

1rneh requested changes Jun 2, 2026

View reviewed changes

victhorlopez force-pushed the bug/2044296 branch from 572d0f0 to 077a53d Compare June 3, 2026 12:00

lissyx reviewed Jun 3, 2026

View reviewed changes

lissyx approved these changes Jun 3, 2026

View reviewed changes

victhorlopez force-pushed the bug/2044296 branch 3 times, most recently from 34d8ebb to b5bcbcd Compare June 3, 2026 13:12

victhorlopez self-assigned this Jun 3, 2026

victhorlopez requested a review from 1rneh June 3, 2026 14:19

victhorlopez force-pushed the bug/2044296 branch from b5bcbcd to e0a61b9 Compare June 3, 2026 14:27

Bug 2044296 - Disable Sync/FxA related tests for firefox enterprise

2f372a0

victhorlopez force-pushed the bug/2044296 branch from e0a61b9 to 2f372a0 Compare June 3, 2026 15:28

victhorlopez assigned 1rneh and unassigned victhorlopez Jun 8, 2026

1rneh removed their request for review June 9, 2026 08:01

Uh oh!

Conversation

victhorlopez commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies / Related Issues

Screenshots

Testing

Uh oh!

victhorlopez commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1rneh left a comment

Choose a reason for hiding this comment

Uh oh!

victhorlopez commented Jun 2, 2026

Uh oh!

1rneh commented Jun 2, 2026

Uh oh!

victhorlopez commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victhorlopez commented Jun 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victhorlopez commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victhorlopez commented Jun 2, 2026 •

edited

Loading

victhorlopez commented Jun 2, 2026 •

edited

Loading

victhorlopez commented Jun 3, 2026 •

edited

Loading

victhorlopez Jun 3, 2026 •

edited

Loading