style(nimbus): turn collapsible elements inside modals static #14488
+115
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moibra05
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
Contributor
Author
|
Contributor
|
@moibra05 when you get a chance can you fix the space here left and right? 🙏 |
Contributor
Author
Oh that space is only there because i didnt change the dates on the experiment i was testing with so they didnt get rendered. normally it'd look like this: |
freshstrangemusic
approved these changes
Feb 2, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
Because - There were several instances in the new results page where collapsible elements were found within modals - Having both is superfluous so we can get rid of the nested collapsiblses This commit - Turns all collapsible elements inside modals into static blocks Fixes #14487
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #14487