Conversation
xlisachan
commented
Mar 25, 2026
| interval: cart.interval as SubplatInterval, | ||
| eligibilityStatus: eligibility.subscriptionEligibilityResult, | ||
| }); | ||
| } catch { |
Contributor
Author
There was a problem hiding this comment.
Should this be a try/catch? 🤔
Member
There was a problem hiding this comment.
If we prefer this to be in a try/catch, it shouldn't eat the error (as this does). We'll want it to hit Sentry at the very least.
That said, it's my opinion that we should bail completely if we fail the eligibility check.
xlisachan
force-pushed
the
PAY-3546
branch
2 times, most recently
from
7296d40 to
98ffa43
Compare
bcolsson
approved these changes
Mar 25, 2026
|
|
||
| ## $endDate (Date) - The end date of the free trial | ||
| checkbox-payment-required-no-charge = A payment method is required to start your free trial. You will not be charged until { $endDate }. | ||
| checkbox-confirm-free-trial-with-legal-links = I authorize { -brand-mozilla } to charge my payment method for the amount shown, according to the <termsOfServiceLink>Terms of Service</termsOfServiceLink> and <privacyNoticeLink>Privacy Notice</privacyNoticeLink>, after the free trial ends on { $endDate }, until I cancel my subscription. |
Contributor
There was a problem hiding this comment.
Suggested change
| checkbox-confirm-free-trial-with-legal-links = I authorize { -brand-mozilla } to charge my payment method for the amount shown, according to the <termsOfServiceLink>Terms of Service</termsOfServiceLink> and <privacyNoticeLink>Privacy Notice</privacyNoticeLink>, after the free trial ends on { $endDate }, until I cancel my subscription. | |
| checkbox-confirm-free-trial-with-legal-links = I authorize { -brand-mozilla } to charge my payment method for the amount shown after the free trial ends on { $endDate }, according to the <termsOfServiceLink>Terms of Service</termsOfServiceLink> and <privacyNoticeLink>Privacy Notice</privacyNoticeLink>, until I cancel my subscription. |
Not a blocker, but this might be somewhat easier to read/parse.
Contributor
Author
There was a problem hiding this comment.
Updated per your suggestion, thanks Bryan! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Issue that this pull request solves
Closes: PAY-3546
Checklist
Put an
xin the boxes that applyScreenshots
Mobile
Tablet+
