feat(payments-next): Add Free Trial section to Subscription Management page#20282
Open
elizabeth-ilina wants to merge 1 commit intomainfrom
Open
feat(payments-next): Add Free Trial section to Subscription Management page#20282elizabeth-ilina wants to merge 1 commit intomainfrom
elizabeth-ilina wants to merge 1 commit intomainfrom
Conversation
elizabeth-ilina
force-pushed
the
PAY-3547-add-free-trial-section-to-subscription-management-page
branch
2 times, most recently
from
9a03645 to
a3f3dd4
Compare
elizabeth-ilina
commented
Mar 30, 2026
|
|
||
| const subplatInterval = getSubplatInterval(interval, intervalCount); | ||
|
|
||
| //const isPastDue = true; |
Contributor
Author
There was a problem hiding this comment.
TODO: remove before merging.
elizabeth-ilina
commented
Mar 30, 2026
| > | ||
| {l10n.getString( | ||
| 'subscription-management-free-trial-heading', | ||
| 'Free trials' |
Contributor
Author
There was a problem hiding this comment.
To match the rest of the page, where headings are plural like Payment details, Active subscriptions, I wrote "Free trials" (with -s at the end), while Figma has "Free trial". Which is better?
elizabeth-ilina
commented
Mar 30, 2026
Comment on lines
+6
to
+7
| subscription-management-free-trial-heading = Free trials | ||
| subscription-management-your-free-trials-aria = Your free trials |
Contributor
Author
There was a problem hiding this comment.
Potentially update based on https://github.com/mozilla/fxa/pull/20282/changes#r3010922866
elizabeth-ilina
force-pushed
the
PAY-3547-add-free-trial-section-to-subscription-management-page
branch
5 times, most recently
from
2c7b6a5 to
c0057cd
Compare
elizabeth-ilina
commented
Mar 30, 2026
|
|
||
| # Heading for mobile only quick links menu | ||
| subscription-management-jump-to-heading = Jump to | ||
| subscription-management-nav-free-trials = Free trials |
Contributor
Author
There was a problem hiding this comment.
Same here, potentially update based on https://github.com/mozilla/fxa/pull/20282/changes#r3010922866
…t page Because: * We need to add a Free Trials section to the Sub Manage page so that a customer can see what free trials they have. This commit: * Adds a new Free Trial section and component, to be rendered on the Subscription Management page, akin to “Payment details” and “Active subscriptions”, that is only rendered if a user has an active trialing subscription. * If the free trial is active, includes details about their upcoming billing cycle, and the option to cancel their free trial * If the free trial could not be converted due to a failed payment method, includes invoice details, and the option to update their payment info * Implements UI for both Desktop and Mobile views Closes #[PAY-3547](https://mozilla-hub.atlassian.net/browse/PAY-3547)
elizabeth-ilina
force-pushed
the
PAY-3547-add-free-trial-section-to-subscription-management-page
branch
from
c0057cd to
bfeffa3
Compare
elizabeth-ilina
commented
Mar 31, 2026
| case 'daily': | ||
| return { | ||
| ftlId: 'free-trial-content-charge-info-with-tax-day', | ||
| fallbackText: `You will be charged ${amount} + ${tax} tax per day after the free trial ends on ${date}.`, |
Contributor
Author
There was a problem hiding this comment.
Question: Figma had (what I assume) just total/monthly, not broken up into totalWithoutTax + tax like we do in other places. Should we display just one number, as per Figma, or break it up into totalWithoutTax + tax?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes #PAY-3547
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Tablet+ :
Mobile:
Other information (Optional)
Any other information that is important to this pull request.