Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy signinConfirmation.skipForEmailAddresses configuration path in favor of the newer skipForEmailRegex, simplifying how sign-in confirmation bypass rules are configured.
Changes:
- Removed
skipConfirmationForEmailAddresseshandling from the account login bypass logic. - Updated config schema/docs to drop
skipForEmailAddressesand clarifyskipForEmailRegex. - Removed the email-address-list-based tests and added a StatsD assertion for the regex-based bypass path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/fxa-auth-server/lib/routes/account.ts | Removes legacy email-list bypass logic; keeps regex-based bypass only. |
| packages/fxa-auth-server/lib/routes/account.spec.ts | Deletes old email-list tests; adds a StatsD assertion for emailAlways bypass; includes formatting churn. |
| packages/fxa-auth-server/config/index.ts | Removes deprecated config schema entry and updates skipForEmailRegex documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1f07f3c to
195502d
Compare
Because: - We added the new skipConfirmationForEmailRegex - And we don't want multiple ways to manage skipping sign in confirmation emails This Commit: - Removes the older config - Removes associated tests Closes: FXA-13360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Closes: FXA-13360
Sister PR: https://github.com/mozilla/webservices-infra/pull/10413 (this is just for stage so we can test with other teams that the regex is correct)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
account.spec.tsis from formattingScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.