Skip to content

chore(auth): Remove skipConfirmationForEmailAddresses config#20288

Open
nshirley wants to merge 1 commit intomainfrom
FXA-13360
Open

chore(auth): Remove skipConfirmationForEmailAddresses config#20288
nshirley wants to merge 1 commit intomainfrom
FXA-13360

Conversation

@nshirley
Copy link
Copy Markdown
Contributor

@nshirley nshirley commented Mar 31, 2026

Because:

  • We added the new skipConfirmationForEmailRegex
  • And we don't want multiple ways to manage skipping sign in confirmation emails

This Commit:

  • Removes the older config
  • Removes associated tests

Closes: FXA-13360

Sister PR: https://github.com/mozilla/webservices-infra/pull/10413 (this is just for stage so we can test with other teams that the regex is correct)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
    • The majority of changes to account.spec.ts is from formatting
    • I also added a test to make sure we're incrementing statsd when the bypass happens
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@nshirley nshirley requested a review from a team as a code owner March 31, 2026 00:10
Copilot AI review requested due to automatic review settings March 31, 2026 00:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy signinConfirmation.skipForEmailAddresses configuration path in favor of the newer skipForEmailRegex, simplifying how sign-in confirmation bypass rules are configured.

Changes:

  • Removed skipConfirmationForEmailAddresses handling from the account login bypass logic.
  • Updated config schema/docs to drop skipForEmailAddresses and clarify skipForEmailRegex.
  • Removed the email-address-list-based tests and added a StatsD assertion for the regex-based bypass path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/fxa-auth-server/lib/routes/account.ts Removes legacy email-list bypass logic; keeps regex-based bypass only.
packages/fxa-auth-server/lib/routes/account.spec.ts Deletes old email-list tests; adds a StatsD assertion for emailAlways bypass; includes formatting churn.
packages/fxa-auth-server/config/index.ts Removes deprecated config schema entry and updates skipForEmailRegex documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nshirley nshirley force-pushed the FXA-13360 branch 2 times, most recently from 1f07f3c to 195502d Compare March 31, 2026 17:09
Because:
 - We added the new skipConfirmationForEmailRegex
 - And we don't want multiple ways to manage skipping sign in
   confirmation emails

This Commit:
 - Removes the older config
 - Removes associated tests

Closes: FXA-13360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants