fix(settings): make non-transparent CMS header push page content down#20292
Open
MagentaManifold wants to merge 1 commit intomainfrom
Open
fix(settings): make non-transparent CMS header push page content down#20292MagentaManifold wants to merge 1 commit intomainfrom
MagentaManifold wants to merge 1 commit intomainfrom
Conversation
Because: * Non-transparent CMS header in split layout covers card content This commit: * only set header positioning to absolute when header background is set * adds a small top margin to the card to ensure a gap between the card and the header Closes FXA-13319
MagentaManifold
force-pushed
the
FXA-13319
branch
from
e3e693d to
c0d91f3
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the AppLayout in fxa-settings to prevent CMS-provided (non-transparent) headers in split layout from overlapping/pinning on top of the page’s card content.
Changes:
- Makes the header use
desktop:absoluteonly under certain split-layout/CMS-background conditions. - Adds additional vertical spacing to the card container to create separation from the header in
mobileLandscape+ breakpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13319
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.