fix(payments-next): Subscription reminder emails showing exclusive tax for non-US customers#20298
Open
elizabeth-ilina wants to merge 1 commit intomainfrom
Conversation
elizabeth-ilina
force-pushed
the
PAY-3601-subscription-reminder-emails-showing-exlusive-tax-for-non-us-customers
branch
4 times, most recently
from
d5dc27d to
3453c9e
Compare
…x for non-US customers Because: * In the subscription renewal reminder emails, European customers are being shown the prices as “€(base amount) + €(tax amount) tax”. This is a pattern that should only be shown to US customers. This commit: * Uses Stripe's total_tax_amounts[].inclusive to determine whether to show the customer a single total or a breakdown of base amount + tax. Closes #[PAY-3601](https://mozilla-hub.atlassian.net/browse/PAY-3601)
elizabeth-ilina
force-pushed
the
PAY-3601-subscription-reminder-emails-showing-exlusive-tax-for-non-us-customers
branch
from
3453c9e to
e461934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes #PAY-3601
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-auth-server/lib/payments/subscription-reminders.tsScreenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.