Skip to content

Fix experiment iteration for rerun#3287

Merged
BenWu merged 1 commit into
mainfrom
benwu/fix-rerun-experiments
Jul 14, 2026
Merged

Fix experiment iteration for rerun#3287
BenWu merged 1 commit into
mainfrom
benwu/fix-rerun-experiments

Conversation

@BenWu

@BenWu BenWu commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fix for #3258 which is causing

  File "/usr/local/lib/python3.11/site-packages/jetstream/cli.py", line 1332, in rerun_config_changed
    rerun_experiments = [exp for exp in all_experiments if exp.do_rerun]
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'ExperimentCollection' object is not iterable

(error)

@BenWu
BenWu requested a review from mikewilli July 13, 2026 16:11
mikewilli
mikewilli approved these changes Jul 14, 2026
View reviewed changes

@mikewilli mikewilli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks right to me, thanks!

@BenWu
BenWu added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 2c1a161 Jul 14, 2026
4 checks passed
@BenWu
BenWu deleted the benwu/fix-rerun-experiments branch July 14, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikewilli mikewilli mikewilli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenWu @mikewilli