Skip to content

fix(extension): repair rotted e2e sidepanel selectors and run them in CI #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmorchard merged 2 commits into from
Sep 15, 2026
+14 −9
Merged

fix(extension): repair rotted e2e sidepanel selectors and run them in CI #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fee0d0
fix(extension): repair rotted e2e sidepanel selectors
lmorchard Sep 15, 2026
032ceab
ci: call the e2e script that actually exists
lmorchard Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ jobs:
run: pnpm --filter pilo-extension exec playwright install-deps chromium

- name: Run extension e2e tests
run: pnpm --filter pilo-extension run test:e2e:headless:chrome
run: pnpm --filter pilo-extension run test:e2e:headless

- name: Upload Playwright report
uses: actions/upload-artifact@v4
Expand Down
5 changes: 5 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,10 @@ packages/core/schemas/
# WXT framework auto-generated files
packages/extension/.wxt/

# Playwright e2e artifacts (gitignored, but prettier still walks them,
# so a local e2e run would otherwise fail `format:check`)
packages/extension/playwright-report/
packages/extension/test-results/

# Dependencies
node_modules/
16 changes: 8 additions & 8 deletions packages/extension/e2e/sidepanel.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe("Sidepanel", () => {
await page.waitForLoadState("networkidle");

// Verify settings page is shown (extension auto-redirects when no API key)
await expect(page.getByText("Pilo Settings")).toBeVisible();
await expect(page.getByRole("heading", { name: "Settings" })).toBeVisible();
await expect(page.getByText("API Key")).toBeVisible();
await expect(page.getByText("Save Settings")).toBeVisible();
});
Expand All @@ -24,8 +24,8 @@ test.describe("Sidepanel", () => {
await page.goto(sidepanelUrl);
await page.waitForLoadState("networkidle");

// Click "Back to Chat" button
await page.getByText("Back to Chat").click();
// Click the "Back to chat" button
await page.getByRole("button", { name: "Back to chat" }).click();

// Wait for chat view to appear
await page.waitForLoadState("networkidle");
Expand All @@ -45,7 +45,7 @@ test.describe("Sidepanel", () => {
await expect(sendButton).toBeDisabled();

// Verify settings button is visible
const settingsButton = page.getByTestId("settings-button");
const settingsButton = page.getByRole("button", { name: "Open settings" });
await expect(settingsButton).toBeVisible();
});

Expand All @@ -55,7 +55,7 @@ test.describe("Sidepanel", () => {
await page.waitForLoadState("networkidle");

// Navigate to chat view
await page.getByText("Back to Chat").click();
await page.getByRole("button", { name: "Back to chat" }).click();
await page.waitForLoadState("networkidle");

const taskInput = page.getByTestId("task-input");
Expand All @@ -77,15 +77,15 @@ test.describe("Sidepanel", () => {
await page.waitForLoadState("networkidle");

// Navigate to chat view first
await page.getByText("Back to Chat").click();
await page.getByRole("button", { name: "Back to chat" }).click();
await page.waitForLoadState("networkidle");

// Click settings button
const settingsButton = page.getByTestId("settings-button");
const settingsButton = page.getByRole("button", { name: "Open settings" });
await settingsButton.click();

// Should be back on settings page
await expect(page.getByText("Pilo Settings")).toBeVisible();
await expect(page.getByRole("heading", { name: "Settings" })).toBeVisible();
await expect(page.getByText("API Key")).toBeVisible();
});
});
Loading