Skip to content

chore: adopt noImplicitOverride and noFallthroughCasesInSwitch repo-wide #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmorchard wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −11
Open

chore: adopt noImplicitOverride and noFallthroughCasesInSwitch repo-wide #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cli/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitOverride": true,
"noFallthroughCasesInSwitch": true,

// Interop and compatibility
"skipLibCheck": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ export class WebAgentEventEmitter extends EventEmitter {
/**
* Override emit to also trigger wildcard listeners
*/
emit(event: string | symbol, ...args: any[]): boolean {
override emit(event: string | symbol, ...args: any[]): boolean {
const result = super.emit(event, ...args);
// Also emit to wildcard listeners if this isn't already a wildcard event
if (event !== "*") {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/loggers/filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export abstract class LoggerFilter extends LoggerWrapper {
private filteredEmitter: WebAgentEventEmitter | null = null;
private handleEvent: ((eventType: string, data: any) => void) | null = null;

initialize(emitter: WebAgentEventEmitter): void {
override initialize(emitter: WebAgentEventEmitter): void {
if (this.emitter) {
this.dispose();
}
Expand All @@ -36,7 +36,7 @@ export abstract class LoggerFilter extends LoggerWrapper {
this.wrappedLogger.initialize(this.filteredEmitter);
}

dispose(): void {
override dispose(): void {
if (this.emitter && this.handleEvent) {
this.emitter.off("*", this.handleEvent);
this.wrappedLogger.dispose();
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/loggers/metricsCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class MetricsCollector extends LoggerWrapper {
super(wrappedLogger);
}

initialize(emitter: WebAgentEventEmitter): void {
override initialize(emitter: WebAgentEventEmitter): void {
this.stepCount = 0;
this.aiGenerationCount = 0;
this.aiGenerationErrorCount = 0;
Expand All @@ -39,7 +39,7 @@ export class MetricsCollector extends LoggerWrapper {
super.initialize(emitter);
}

dispose(): void {
override dispose(): void {
if (this.emitter) {
this.eventCounts.clear();
this.emitter.off("*", this.handleEventCount);
Expand Down
2 changes: 2 additions & 0 deletions packages/core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitOverride": true,
"noFallthroughCasesInSwitch": true,

// Interop and compatibility
"skipLibCheck": true,
Expand Down
9 changes: 3 additions & 6 deletions packages/extension/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
// WXT 0.21's generated tsconfig enables these; opting out keeps the
// extension typecheck aligned with the rest of the monorepo (it also
// compiles pilo-core sources via the paths aliases below).
// Whether to adopt them monorepo-wide is tracked in
// noImplicitOverride and noFallthroughCasesInSwitch, which WXT 0.21's
// generated tsconfig also enables, are now on repo-wide. Only
// noUncheckedIndexedAccess remains opted out; see
// https://github.com/mozilla/pilo/issues/688
"noUncheckedIndexedAccess": false,
"noImplicitOverride": false,
"noFallthroughCasesInSwitch": false,
"jsx": "react-jsx",
"lib": ["ESNext", "DOM", "WebWorker"],
"paths": {
Expand Down
2 changes: 2 additions & 0 deletions packages/server/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitOverride": true,
"noFallthroughCasesInSwitch": true,

// Interop and compatibility
"skipLibCheck": true,
Expand Down
Loading