Skip to content

Add a GitHub actions check test262.properties #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbrail merged 8 commits into from
Aug 31, 2025
Merged

Add a GitHub actions check test262.properties #2052

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
054c415
Add a GitHub actions check test262.properties
gbrail Aug 30, 2025
c894649
Make test file executable
gbrail Aug 30, 2025
d05dab7
Try another approach.
gbrail Aug 30, 2025
51a08e3
Typo
gbrail Aug 30, 2025
ed9d9a6
Fix script
gbrail Aug 30, 2025
019b9e1
Innocent change, let's see what happens
gbrail Aug 30, 2025
a8b1119
Revert "Innocent change, let's see what happens"
gbrail Aug 30, 2025
ef2d296
Now try moving the new check to the main action
gbrail Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,24 @@ jobs:
with:
name: reports-java-11
path: '*/build/reports'
- name: Check current state of test262.properties
id: hashBefore
run: echo "hash=${{ hashFiles('./tests/testsrc/test262.properties') }}" >> $GITHUB_OUTPUT
- name: Run test262 tests
env:
RHINO_TEST_JAVA_VERSION: "11"
run: >-
./gradlew :tests:test --tests Test262SuiteTest -DupdateTest262properties
- name: Check updated state of test262.properties
id: hashAfter
run: echo "hash=${{ hashFiles('./tests/testsrc/test262.properties') }}" >> $GITHUB_OUTPUT
- name: Compare test262 results
run: |
if [ "${{ steps.hashBefore.outputs.hash }}" != "${{ steps.hashAfter.outputs.hash }}" ]; then

@rPraml rPraml Aug 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might check for modification with git diff / git status here.

How long does this step take?
As long as I understand, this step executes ALL 262 tests... And the java 11 test run executes then again (but only the not excluded ones) - so it should be possible to exclude them (or regenerate the props file in the java 11 test run)

I'm fine with your changes and the above are suggestions, that can (or not) be done in further PRs 👍

echo "The test262.properties file was not updated properly."
echo "Please follow the instructions in tests/README.md to update it."
git --no-pager diff ./tests/testsrc/test262.properties
exit 1
else
echo "The test262.properties file is up to date."
fi