Add lazy source code provision.#2450
Draft
aardvark179 wants to merge 5 commits into
Draft
Conversation
Contributor
Author
|
As part of porting this I did quite a bit of tidying up in our compiler interface, which might be worth splitting out into a separate PR. I'm also not sure I like the If anybody has a good suggestion on how to slice this I'd be interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases where we are loading large quantities of JavaScript we would like to have source code available, but do not want to pay the resource cost of having those strings on the heap all the time if they can be retrieved from a database, files, or other sources. This PR introduces a pluggable system that can lazily resolve source code requests only when required. If the feature is not used then we pay a cost of 16 bytes per source for the
EagerSourceCodeProvider.