Write stats to cache_stats_file after compile#2452
Open
zmc wants to merge 1 commit intomozilla:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
==========================================
+ Coverage 71.18% 71.23% +0.05%
==========================================
Files 64 64
Lines 35588 35605 +17
==========================================
+ Hits 25333 25364 +31
+ Misses 10255 10241 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
did you evaluate the perf impact of this? thanks |
Collaborator
|
What's the use case for this? It seems pretty exotic. I don't really mind since it's opt-in, anyway... |
Collaborator
|
rustfmt is needed btw |
Signed-off-by: Zack Cerza <zack@cerza.org>
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #33
This would be my first contribution to this project, and I am relatively inexperienced with Rust, so I'd love feedback on this.