feat(redis): add Redis Sentinel support for HA cache discovery#2618
feat(redis): add Redis Sentinel support for HA cache discovery#2618ex0a wants to merge 3 commits intomozilla:mainfrom
Conversation
ex0a
commented
Feb 16, 2026
- Add build_sentinel() function to discover Redis master via Sentinel
- Parse redis-sentinel://host:port,host2:port2/master_name URLs
- Query sentinels with SENTINEL GET-MASTER-ADDR-BY-NAME
- Add comprehensive logging for debugging discovery issues
- Support password auth and optional DB selection
- Route sentinel URLs from endpoint config path in cache.rs
|
sorry, it conflicts |
|
What would you suggest? I'm using this personally but thought it might help someone else |
|
Hi @ex0a , You should rebase your changes to the latest Then you need to push your changes to your branch. That's should be fine! |
|
CC @Xuanwo IMO, we should implement the Redis Sentinel support as a part of the OpenDAL. And just use it here. Possibly, it's already done. |
d088922 to
5288c2d
Compare
|
Thanks for the review! I've pushed updates addressing both points: |
- Add build_sentinel() function to discover Redis master via Sentinel - Parse redis-sentinel://host:port,host2:port2/master_name URLs - Query sentinels with SENTINEL GET-MASTER-ADDR-BY-NAME - Add comprehensive logging for debugging discovery issues - Support password auth and optional DB selection - Route sentinel URLs from endpoint config path in cache.rs - Warn when username/password/db are provided with sentinel URLs - Fix redis feature gating with dep:redis
5288c2d to
b477146
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
- Coverage 72.74% 72.54% -0.20%
==========================================
Files 68 68
Lines 36985 37079 +94
==========================================
- Hits 26903 26900 -3
- Misses 10082 10179 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
please fix the jobs |