Skip to content

msvc: Append the default .pdb extension for the /Fd argument#2621

Open
ikolomiko wants to merge 3 commits intomozilla:mainfrom
ikolomiko:main
Open

msvc: Append the default .pdb extension for the /Fd argument#2621
ikolomiko wants to merge 3 commits intomozilla:mainfrom
ikolomiko:main

Conversation

@ikolomiko
Copy link

MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.

Fixes #2620

MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.82%. Comparing base (146f4df) to head (922500d).

Files with missing lines Patch % Lines
src/compiler/msvc.rs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2621      +/-   ##
==========================================
- Coverage   72.82%   72.82%   -0.01%     
==========================================
  Files          68       68              
  Lines       37114    37120       +6     
==========================================
+ Hits        27029    27031       +2     
- Misses      10085    10089       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2026

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing ikolomiko:main (922500d) with main (146f4df)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AJIOB
Copy link
Contributor

AJIOB commented Feb 21, 2026

@ikolomiko, please, recheck the format: looks like it's failed

@ikolomiko
Copy link
Author

Oopsies, fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sccache fails to find the PDB file given with /Fd when the .pdb file extension is omitted

3 participants