chore: sync upstream changes (82adf904)#88
Merged
Conversation
This commit exposes the new feature of ignoring invalid rules during compilation. It is set to False by default but if turned on than errors are not raised on compilation failure and any ignored rules will be returned when calling the `Compiler::ignored_rules()` method. It returns a list of IgnoredRule objects which have two properties: name and reason. This makes it easier for users of this API to figure out why a rule was ignored. Now they can check the `reason` property on `IgnoredRule` to see if it is any of the IgnoredRuleReason values from the exposed enum.
The previous approach iterated over a range of pattern IDs and then performed a hash map lookup for each to retrieve filesize bounds and header constraints. This change modifies the `Rules` API to return the entire `FxHashMap`, enabling the scanner to directly iterate over the `(PatternId, Constraint)` pairs. This avoids redundant hash map lookups and improves performance in `ScanContext::update_rules_matching`.
willdurand
marked this pull request as ready for review
July 17, 2026 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the latest changes from VirusTotal/yara-x.
Commits included