Fix: #259 Windows grep backslash handling in _grep#339
Open
wasiqnauman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Windows bug in code_puppy.tools.file_operations._grep where search strings containing backslashes were corrupted before being passed to ripgrep.
The root cause was POSIX shlex.split(search_string), which treats \ as an escape character. On Windows that broke common searches like \bhello\b, \d+, foo.bar, and path-like input such as C:\Users\me.
Changes
use Windows-safe argument splitting for _grep
preserve backslashes in regex and path-like input
surface ripgrep errors instead of silently returning zero matches
add regression tests for Windows backslash handling and ripgrep error propagation
Notes
grep is still regex-based by default. A raw search like C:\Users\me now returns the real ripgrep regex error instead of looking like “no matches”. For literal path searches, use -F "C:\Users\me".
Passed:
pytest tests/tools/test_file_operations_coverage.py -q
pytest tests/tools/test_file_operations_coverage.py -q -k grep
Manual Windows smoke test:
\bhello_world\b matched
\d+ matched
-F "C:\Users\me" matched literal Windows paths