Conversation
Collaborator
|
Late to the party since this is merged, but for the record:
|
Owner
Author
|
Hey, these are relevant still. I agree. Regarding Indexing, it is very helpful as this is the kind of feedback that comes with people (other than me) trying to implement the document. I think we should have text (either in body either in appendix) that gives the formula for the phasing and seam effect. It's not well documented online last time I checked. If we get very serious about it, some test vectors could be added to appendix as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR propose two changes following recent feedback for the upcoming draft version: