cocoa-cb: re-enable wid (NSView) embedding on macOS for libmpv use
#17221
+258
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softworkz
force-pushed
the
submit_reenable_mac_wid
branch
2 times, most recently
from
e332032 to
0b00ae9
Compare
softworkz
changed the title
wid (NSView) embedding on macOS for libmpv use
In version 0.37, support for the old cocoa backend has been dropped, which unfortunately also removed the ability of embedding mpv in native applications by specifying a wid - which is still working for all other platforms. This PR aims to remedy that situation by leveraging the existing cocoa-cb implementation which already had just about everything that it takes and it has been merely about gluing loose ends together and omitting those parts that are specific to standalone application use, like NSApplication and NSWindow.
softworkz
force-pushed
the
submit_reenable_mac_wid
branch
from
0b00ae9 to
b4aaef0
Compare
This comment was marked as spam.
This comment was marked as spam.
diffray-bot
reviewed
Jan 2, 2026
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
When there's once another AI bot coming to respond, then I'll close this PR. |
Contributor
Why? Didn't you request all of these to spam this PR? |
Contributor
|
diffray-bot is spam advertising campaign (look at all these utm_source links) "review"ing code without permission aidenybai/react-grab#102 (comment) Just block it. |
Member
Done. |
Contributor
Author
I didn't request anything and I never heard of diffray before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 0.37, support for the old cocoa backend had been dropped, which unfortunately also removed the ability of embedding mpv in native applications by specifying a wid - which is still working for all other platforms.
This PR aims to remedy that situation by leveraging the existing cocoa-cb implementation which already has just about everything that it takes and it has been merely about gluing loose ends together and omitting those parts that are specific to standalone application use, like NSApplication and NSWindow.