Skip to content

Conversation

@oliped
Copy link

@oliped oliped commented Jan 14, 2025

No description provided.

@mrDIMAS
Copy link
Owner

mrDIMAS commented Jan 14, 2025

I'm confused why this change is needed in the first place. The output buffer is allocated only once already - when the output thread starts, it becomes "stuck" in an infinite loop inside run_send_loop until the output device is running. So there's no multiple memory allocations. I might miss something of course.

@mrDIMAS
Copy link
Owner

mrDIMAS commented Jan 15, 2025

Could you please share your motivation of why these changes are needed?

@berkus
Copy link

berkus commented Jan 15, 2025

Looks like your old code is ok, I don't currently see why it should be changed like this. In the changed code DataSender has to carry around a Box, which makes it less flexible even.

@oliped
Copy link
Author

oliped commented Feb 11, 2025

Ah, my honest mistake. I thought run_send_loop is called on each iteration.

@oliped oliped closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants